Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tagFilter for traverse #5137

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Dec 28, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close https://github.com/vesoft-inc/nebula-ent/issues/1668
close https://github.com/vesoft-inc/nebula-ent/issues/2022

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Dec 28, 2022
xtcyclist
xtcyclist previously approved these changes Dec 28, 2022
@@ -1641,6 +1641,14 @@ class Traverse final : public GetNeighbors {
firstStepFilter_ = filter;
}

Expression* tagFilter() const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference from vertex filter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, but the vertexfilter will not be pushed down to the storage layer, tagFilter will

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And vertex filter will be moved to firstStepFilter in the optimizer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much filter is really confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vertexFilter and edgeFilter are in the graph layer. Under some conditions, they cannot be pushed to the storage layer, so they continue to filter at the graph layer. firstStepFilter is the first step version of the filter, which is pushed down to the storage layer, but they cannot filter vertex. So tagFilter is added, if the vertex's attribute does not satisfy tagFilter, it will be filtered out directly in the storage layer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should not design such a large-grained plan node in the future.

@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test ready for review type/bug Type: something is unexpected labels Dec 28, 2022
@Sophie-Xie Sophie-Xie merged commit 967a8c9 into vesoft-inc:master Dec 29, 2022
@nevermore3 nevermore3 deleted the fix_issue1668 branch December 29, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants