Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance MemoryStats to avoid the false sharing effect on the CPU cache #5140

Merged
merged 4 commits into from
Dec 28, 2022
Merged

Enhance MemoryStats to avoid the false sharing effect on the CPU cache #5140

merged 4 commits into from
Dec 28, 2022

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Dec 28, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Description:

As discussed here: https://github.com/vesoft-inc/nebula/pull/5082/files#r1057092947
image

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

@czpmango czpmango added ready-for-testing PR: ready for the CI test ready for review labels Dec 28, 2022
codesigner
codesigner previously approved these changes Dec 28, 2022
View reviewed changes
Aiee
Aiee previously approved these changes Dec 28, 2022
View reviewed changes
codesigner
codesigner reviewed Dec 28, 2022
View reviewed changes
src/common/memory/MemoryTracker.h Outdated
#if defined(__cpp_lib_hardware_interference_size)
L1_CACHE_LINE_SIZE = hardware_destructive_interference_size;
#else
L1_CACHE_LINE_SIZE = 64;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor：cache line size is same for all level of cpu caches,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@czpmango czpmango dismissed stale reviews from Aiee and codesigner via c89a121 December 28, 2022 08:44
@Sophie-Xie Sophie-Xie merged commit ff4cb8c into vesoft-inc:master Dec 28, 2022
@wey-gu wey-gu mentioned this pull request Dec 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codesigner codesigner codesigner approved these changes

@Aiee Aiee Aiee approved these changes

@dutor dutor Awaiting requested review from dutor

@jievince jievince Awaiting requested review from jievince

@Shylock-Hg Shylock-Hg Awaiting requested review from Shylock-Hg

@yixinglu yixinglu Awaiting requested review from yixinglu

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@czpmango @codesigner @Aiee @Sophie-Xie