Fix the bad type evaluated from AttributeExpression on vertices #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on #5149. |
xtcyclist
changed the title
xtcyclist
force-pushed
the
fix_some_bad_type
branch
from
e078996
to
ca0f0ce
Compare
xtcyclist
added
ready-for-testing
xtcyclist
requested review from
Aiee,
codesigner,
czpmango,
jievince,
Shylock-Hg,
yixinglu and
nevermore3
xtcyclist
force-pushed
the
fix_some_bad_type
branch
from
43ff142
to
855ea29
Compare
xtcyclist
force-pushed
the
fix_some_bad_type
branch
from
855ea29
to
d08ee1b
Compare
czpmango
reviewed
Dec 30, 2022
Comment on lines
+102
to
+105
| if (lvalue.isNull() && lvalue.getNull() == NullType::UNKNOWN_PROP) { | ||
| // return UNKNOWN_PROP as plain null values, instead of bad type. | ||
| return Value::kNullValue; | ||
| } |
There was a problem hiding this comment.
Better to modify the behivor of isNull.
There was a problem hiding this comment.
Using existing methods of Value for now.
Aiee
approved these changes
Dec 30, 2022
jievince
approved these changes
Dec 30, 2022
nevermore3
approved these changes
Dec 30, 2022
codesigner
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close https://github.com/vesoft-inc/nebula-ent/issues/2020
Close #5153
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: