Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Delete some fatals and comment some CHECKs #5439

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Mar 27, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Description:

Sort out the code that may cause crash in the implementation of the expression visitor

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

@czpmango czpmango requested review from xtcyclist, nevermore3, Shylock-Hg, jievince and Aiee and removed request for xtcyclist March 27, 2023 07:38
@czpmango czpmango added ready-for-testing PR: ready for the CI test ready for review labels Mar 27, 2023
@nevermore3
Copy link
Contributor

Is there a relevant test case

@Sophie-Xie Sophie-Xie merged commit bb4ee8c into vesoft-inc:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants