fix traverse build path memory tracker #5619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codesigner
approved these changes
Jul 3, 2023
|
this patch need pick into 3.5 @Sophie-Xie |
fix this one？ #5615 |
yixinglu
approved these changes
Jul 3, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #5619 +/- ##
==========================================
+ Coverage 77.03% 78.27% +1.23%
==========================================
Files 1130 1130
Lines 85341 85346 +5
==========================================
+ Hits 65744 66802 +1058
+ Misses 19597 18544 -1053
☔ View full report in Codecov by Sentry. |
YES |
Closed
Sophie-Xie
pushed a commit
that referenced
this pull request
Jul 20, 2023
Sophie-Xie
added a commit
that referenced
this pull request
Jul 20, 2023
* fix traverse build path memory tracker (#5619) * Optimize the write performance when host is down (#5571) * Optimize the write performance when host is down * fix the comments --------- Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Fix too many logs print when listing sessions (#5618) * Set min_level_for_custom_filter as 0 by default to delete expired d… (#5622) Reset min_level_for_custom_filter as 0 by default to delete expired data during compaction * Revert "Revert "Change ccache to sccache"" (#5623) * Revert "Revert "Change ccache to sccache" (#5613)" This reverts commit 08a5d90. * Update pull_request.yml * Revert "Change ccache to sccache" (#5627) Revert "Revert "Revert "Change ccache to sccache"" (#5623)" This reverts commit c1b433d. * fix all path memory tracker (#5621) * fix all path memory tracker * fix error * Update pull_request.yml enable sccache debug log * Update pull_request.yml add ninja -v * Update pull_request.yml * Update pull_request.yml * Update pull_request.yml * Update pull_request.yml --------- Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Fix edge all predicate embedding when generating path (#5631) * Fix edge all predicate embedding when generate path * fmt * Enhancement/eliminate invalid filter (#5634) * Fix crash double free of expr. * Change issue id. * Elimintate invalid property filter. * support find circular (#5636) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix allpath memory tracker (#5640) fix allpath memory traker * fix_delete_validate (#5645) add test case --------- Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: Ryan <ydlu1987@gmail.com> Co-authored-by: Songqing Zhang <zhangsongqing164@163.com> Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Sep 14, 2023
…ft-inc#5619) (vesoft-inc#2880) fix traverse build path memory tracker (vesoft-inc#5619) Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#5615
Description:
before
now
memory can be monitored now
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: