Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve host's leader number bounds when doing leader balance #5670

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

songqing
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: part of 5669

Description:

When doing leader balance, we can choose a leader number bound for each host, however, the current method is a little simple.

How do you solve it?

The gflags "leader_balance_deviation" has been imported, and we can use it to set the host bound dynamically.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Aug 10, 2023
@songqing
Copy link
Contributor Author

CI failed, but it seems the test is not stable as the same test can be passed in other test env, besides, the failed test seems have nothing to do with my change.

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job~

@songqing
Copy link
Contributor Author

songqing commented Sep 4, 2023

@Sophie-Xie Could you help to trigger the CI test again?

@Sophie-Xie Sophie-Xie merged commit 3a74633 into vesoft-inc:master Sep 5, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants