fix some issue of Optimize the write performance when host is down #5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g rpc and raft call
tangyuanzhang
changed the title
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5673 +/- ##
==========================================
+ Coverage 77.10% 78.22% +1.12%
==========================================
Files 1133 1133
Lines 85884 85928 +44
==========================================
+ Hits 66220 67221 +1001
+ Misses 19664 18707 -957
☔ View full report in Codecov by Sentry. |
yixinglu
previously approved these changes
Aug 21, 2023
dutor
reviewed
Aug 31, 2023
There was a problem hiding this comment.
Thanks for this contribution.
@cangfengzhs @critical27 Please take a look whether it's OK to take several times of TIMEOUT as host down.
src/kvstore/raftex/Host.cpp
Outdated
Comment on lines
431
to
434
| // If we keeps receiving NOT_OPEN exception after some HB intervals, | ||
| // we can assume that the peer is down so we mark paused_ as true | ||
| if (exception && exception->getType() == TransportException::NOT_OPEN) { | ||
| if (exception && (exception->getType() == TransportException::NOT_OPEN || | ||
| exception->getType() == TransportException::TIMED_OUT)) { |
There was a problem hiding this comment.
Please update the comment accordingly.
critical27
approved these changes
Sep 18, 2023
cangfengzhs
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description ：#5672