Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix allpath limit #5699

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Aug 31, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close https://github.com/vesoft-inc/nebula-ent/issues/3098

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 92.85% and project coverage change: +1.20% 🎉

Comparison is base (793c914) 77.08% compared to head (20b8470) 78.28%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5699      +/-   ##
==========================================
+ Coverage   77.08%   78.28%   +1.20%     
==========================================
  Files        1133     1133              
  Lines       85800    85835      +35     
==========================================
+ Hits        66138    67199    +1061     
+ Misses      19662    18636    -1026     
Files Changed Coverage Δ
src/graph/executor/algo/AllPathsExecutor.h 100.00% <ø> (ø)
src/graph/planner/plan/Algo.cpp 33.33% <50.00%> (+0.23%) ⬆️
src/graph/executor/algo/AllPathsExecutor.cpp 84.67% <100.00%> (+3.12%) ⬆️
...graph/optimizer/rule/PushLimitDownAllPathsRule.cpp 89.65% <100.00%> (+0.36%) ⬆️
src/graph/planner/plan/Algo.h 100.00% <100.00%> (ø)

... and 93 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sophie-Xie Sophie-Xie merged commit ba3eb82 into vesoft-inc:master Aug 31, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants