Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix match shortestPath find loop #5738

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Oct 15, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close https://github.com/vesoft-inc/nebula-ent/issues/3025

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (798d48e) 77.08% compared to head (0c69880) 78.22%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5738      +/-   ##
==========================================
+ Coverage   77.08%   78.22%   +1.13%     
==========================================
  Files        1133     1133              
  Lines       85899    85980      +81     
==========================================
+ Hits        66218    67255    +1037     
+ Misses      19681    18725     -956     
Files Coverage Δ
src/graph/executor/algo/ShortestPathBase.cpp 52.02% <100.00%> (+2.38%) ⬆️
src/graph/executor/algo/ShortestPathBase.h 50.00% <ø> (ø)
src/graph/optimizer/OptContext.h 100.00% <ø> (ø)
src/graph/optimizer/Optimizer.h 100.00% <ø> (ø)
src/graph/scheduler/Scheduler.cpp 82.35% <100.00%> (+1.70%) ⬆️
src/graph/visitor/PrunePropertiesVisitor.h 50.00% <ø> (ø)
src/graph/executor/algo/BatchShortestPath.cpp 97.03% <85.71%> (-0.24%) ⬇️
src/graph/executor/algo/SingleShortestPath.cpp 95.78% <75.00%> (-0.33%) ⬇️
src/graph/optimizer/OptGroup.cpp 73.30% <92.30%> (+0.44%) ⬆️
src/graph/optimizer/Optimizer.cpp 90.37% <90.47%> (-0.03%) ⬇️
... and 1 more

... and 99 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sophie-Xie Sophie-Xie merged commit 496cfb0 into vesoft-inc:master Oct 16, 2023
4 of 5 checks passed
@nevermore3 nevermore3 deleted the fix_shortestpath_find_loop branch October 16, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants