Skip to content

fix limit bug#5787

Merged
yixinglu merged 3 commits intovesoft-inc:masterfrom
nevermore3:fix_limit
Dec 21, 2023
Merged

fix limit bug#5787
yixinglu merged 3 commits intovesoft-inc:masterfrom
nevermore3:fix_limit

Conversation

@nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Dec 21, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close https://github.com/vesoft-inc/nebula-ent/issues/3390

Description:

when invoke the erase interface, if the iterator you pass in exceeds the range of std::vector (that is, greater than the end() of std::vector), then this will be undefined behavior

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu merged commit b84afe6 into vesoft-inc:master Dec 21, 2023
@nevermore3 nevermore3 deleted the fix_limit branch December 21, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review ready-for-testing PR: ready for the CI test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants