Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:a single node self-loop when executing NOLOOP #5805

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

AntiTopQuark
Copy link
Contributor

@AntiTopQuark AntiTopQuark commented Jan 13, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

fix #5764

Description:

Use of the noloop parameter in the find path statement does not exclude the self-loop case

How do you solve it?

New logical judgement on self-loops in the AllPathsExecutor::doBuildPath() function

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Jan 16, 2024
@yixinglu yixinglu linked an issue Jan 16, 2024 that may be closed by this pull request
@AntiTopQuark
Copy link
Contributor Author

image
The two results look the same, but pytest thinks they are different and reports an error?

@AntiTopQuark
Copy link
Contributor Author

image
Also I am getting some session related errors when compiling tests in docker, is this as expected?

@Shinji-IkariG Shinji-IkariG merged commit 5e9d934 into vesoft-inc:master Jan 18, 2024
2 of 5 checks passed
@Salieri-004
Copy link
Contributor

image The two results look the same, but pytest thinks they are different and reports an error?

This is not as expected and may be a problem with our testing framework. Thanks for your help.

@Salieri-004 Salieri-004 mentioned this pull request Feb 1, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The param: ”noloop“ in find path does not exclude ”self-loop“
4 participants