Implemented the StorageClient #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. |
1 similar comment
|
Build succeeded. |
|
Thanks for reviewing the code and for many good points. Will revise the diff and update it soon |
dutor
reviewed
Jan 6, 2019
dutor
reviewed
Jan 6, 2019
dutor
reviewed
Jan 6, 2019
dutor
reviewed
Jan 6, 2019
dutor
reviewed
Jan 6, 2019
|
Build succeeded. |
|
Build failed. |
|
As @dangleptr said, the testing failed due to the changes in another patch. Please perform a rebase to fix this. |
|
@dangleptr I changed Also, I could not find the place where to set the -1 as the partition id for the entire host failure. I'm afraid I might miss that part, because we want to return the error code for every single partition |
|
Build failed. |
|
Log_cas_test failed. I'll take care of it |
dangleptr
reviewed
Jan 17, 2019
|
Unit testing passed. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
* Implemented the StorageClient * Refactored StorageClient to remove duplicate and similar code * Addressed @dangleptr's and @dutor's comments * Refactored StorageClient to not re-use thrift response objects * Addressed @dangleptr's comments and rebased
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Implemented the StorageClient * Refactored StorageClient to remove duplicate and similar code * Addressed @dangleptr's and @dutor's comments * Refactored StorageClient to not re-use thrift response objects * Addressed @dangleptr's comments and rebased
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #58
Farewell 2018, and Hello 2019!!
The implementation is partially done. We need to implement the re-try logic when the leader changes. The framework is there, just need to fill it up. Will do it in next PR