Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph failed to register config to meta. #792

Merged
merged 9 commits into from Aug 27, 2019

Conversation

@critical27
Copy link
Contributor

commented Aug 16, 2019

  1. Let meta client retry to register configs to meta server.
  2. Add gflags.json to avoid hard code config mode, and all default config mode is IMMUTABLE.
  3. Add related command in complete.json

close #780

@critical27 critical27 changed the title Fix Fix graph failed to register config to meta. Aug 16, 2019

@critical27 critical27 force-pushed the critical27:fix branch from 5fd4baf to df169ed Aug 16, 2019

src/meta/GflagsManager.cpp Show resolved Hide resolved
src/meta/client/MetaClient.cpp Outdated Show resolved Hide resolved
@critical27

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

Jenkins go

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Unit testing passed.

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Unit testing failed.

src/meta/GflagsManager.cpp Outdated Show resolved Hide resolved
@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

Unit testing passed.

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Unit testing failed.

@critical27

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

Jenkins go

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Unit testing passed.

src/meta/GflagsManager.cpp Outdated Show resolved Hide resolved
share/resources/gflags.json Show resolved Hide resolved
@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Unit testing passed.

@laura-ding
Copy link
Contributor

left a comment

Well done

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Unit testing passed.

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Unit testing passed.

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Unit testing passed.

@dangleptr dangleptr merged commit c358d53 into vesoft-inc:master Aug 27, 2019

1 check passed

UnitTest All tests passed.
Details

@critical27 critical27 deleted the critical27:fix branch Aug 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.