Fix graph failed to register config to meta. #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
dangleptr,
darionyaphet,
laura-ding and
whitewum
laura-ding
reviewed
Aug 16, 2019
|
Jenkins go |
|
Unit testing passed. |
|
Unit testing failed. |
wadeliuyi
reviewed
Aug 16, 2019
wadeliuyi
reviewed
Aug 16, 2019
wadeliuyi
reviewed
Aug 16, 2019
|
Unit testing passed. |
laura-ding
reviewed
Aug 20, 2019
|
Unit testing failed. |
|
Jenkins go |
|
Unit testing passed. |
dangleptr
reviewed
Aug 21, 2019
|
Unit testing passed. |
dangleptr
reviewed
Aug 26, 2019
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
dangleptr
approved these changes
Aug 27, 2019
laura-ding
approved these changes
Aug 27, 2019
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
* register gflags in meta client * parse json * try register at first operation * address @laura-ding's comments * fix ut, address comments * address laura-dings's comments * address comments * address @dangleptr's comments, update gflags.json * address @dangleptr's comments
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* register gflags in meta client * parse json * try register at first operation * address @laura-ding's comments * fix ut, address comments * address laura-dings's comments * address comments * address @dangleptr's comments, update gflags.json * address @dangleptr's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gflags.jsonto avoid hard code config mode, and all default config mode isIMMUTABLE.close #780