Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cn2 #793

Merged
merged 6 commits into from Aug 19, 2019
Merged

Cn2 #793

merged 6 commits into from Aug 19, 2019

Conversation

Amber1990Zhang
Copy link
Contributor

No description provided.

@Amber1990Zhang Amber1990Zhang marked this pull request as ready for review August 16, 2019 08:53
whitewum
whitewum reviewed Aug 17, 2019
View reviewed changes
.../cn_manual_doc/cn_Statement_Syntax/cn_Data_Definition_Statements/cn_Alter_Tag_Edge_Syntax.md Outdated Show resolved Hide resolved
docs/cn_manual_doc/cn_Statement_Syntax/cn_Data_Definition_Statements/Drop_Tag_Syntax.md Outdated Show resolved Hide resolved
...yntax/cn_Data_Administration_Statements/cn_Account_Management_Statements/Drop_User_Syntax.md Outdated Show resolved Hide resolved
docs/cn_manual_doc/cn_Statement_Syntax/DATA_Manipulation_Statements/fetch_Syntax.md Outdated Show resolved Hide resolved
docs/cn_manual_doc/cn_Statement_Syntax/DATA_Manipulation_Statements/WHERE_Syntax.md Outdated Show resolved Hide resolved
docs/cn_manual_doc/cn_Statement_Syntax/DATA_Manipulation_Statements/WHERE_Syntax.md Outdated Show resolved Hide resolved
docs/cn_manual_doc/cn_Statement_Syntax/DATA_Manipulation_Statements/PIPE_Syntax.md Outdated Show resolved Hide resolved
docs/cn_manual_doc/cn_Statement_Syntax/DATA_Manipulation_Statements/INSERT_EDGE_Syntax.md Outdated Show resolved Hide resolved
docs/cn_doc/cn-get-started.md Outdated
vesoft/nebula-graph latest 1afd60e223ca 4 weeks ago 401MB
```

<!-- If `docker` is slow when pulling the image, configure a new mirror.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for Chinese user, the mirros are ok. show them

sherman-the-tank
sherman-the-tank reviewed Aug 19, 2019
View reviewed changes
Copy link
Member

@sherman-the-tank sherman-the-tank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort! 👍

I just finished reading README.md, I will try to finish by today

Regarding the file names, I think the locale usually goes at the end, such as README-cn.md

docs/cn_doc/cn-README.md Outdated Show resolved Hide resolved
docs/cn_doc/cn-README.md Show resolved Hide resolved
docs/cn_doc/cn-README.md Outdated Show resolved Hide resolved
docs/cn_doc/cn-README.md Outdated Show resolved Hide resolved
docs/cn_doc/cn-README.md Outdated Show resolved Hide resolved
whitewum
whitewum previously approved these changes Aug 19, 2019
View reviewed changes
@jude-zhu jude-zhu added the ready-for-testing PR: ready for the CI test label Aug 19, 2019
@whitewum
Copy link
Contributor

I'll fix the errors with @jude-zhu

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit beaf190 into vesoft-inc:master Aug 19, 2019
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@Amber1990Zhang @dangleptr
add Chinese docs 2 (vesoft-inc#793)
f984c3a
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this pull request May 10, 2022
@critical27 @Sophie-Xie
skip leader lease check in snapshot manager (vesoft-inc#793)
e897ad6 
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherman-the-tank sherman-the-tank sherman-the-tank left review comments

@whitewum whitewum whitewum approved these changes

@jude-zhu jude-zhu jude-zhu approved these changes

@dutor dutor Awaiting requested review from dutor

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Amber1990Zhang @whitewum @nebula-community-bot @sherman-the-tank @jude-zhu @dangleptr