Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cn2 #793

Merged
merged 6 commits into from Aug 19, 2019

Conversation

@Amber1990Zhang
Copy link
Contributor

commented Aug 16, 2019

No description provided.

@Amber1990Zhang Amber1990Zhang marked this pull request as ready for review Aug 16, 2019

@Amber1990Zhang Amber1990Zhang requested review from dutor, jude-zhu and whitewum Aug 16, 2019

vesoft/nebula-graph latest 1afd60e223ca 4 weeks ago 401MB
```

<!-- If `docker` is slow when pulling the image, configure a new mirror.

This comment has been minimized.

Copy link
@whitewum

whitewum Aug 17, 2019

Contributor

for Chinese user, the mirros are ok. show them

@sherman-the-tank
Copy link
Member

left a comment

Thanks for the effort! 👍

I just finished reading README.md, I will try to finish by today

Regarding the file names, I think the locale usually goes at the end, such as README-cn.md

docs/cn_doc/cn-README.md Outdated Show resolved Hide resolved
docs/cn-doc/cn-README.md Show resolved Hide resolved
docs/cn_doc/cn-README.md Outdated Show resolved Hide resolved
docs/cn_doc/cn-README.md Outdated Show resolved Hide resolved
docs/cn_doc/cn-README.md Outdated Show resolved Hide resolved
@whitewum

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

I'll fix the errors with @jude-zhu

@nebula-community-bot

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Unit testing passed.

@dangleptr dangleptr merged commit beaf190 into vesoft-inc:master Aug 19, 2019

1 check passed

UnitTest All tests passed.
Details

@Amber1990Zhang Amber1990Zhang deleted the Amber1990Zhang:cn2 branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.