Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate thrift code for Python #891

Merged
merged 3 commits into from Sep 9, 2019
Merged

Generate thrift code for Python #891

merged 3 commits into from Sep 9, 2019

Conversation

laura-ding
Copy link
Contributor

No description provided.

@darionyaphet
Copy link
Contributor

I have tested this update, it seems couldn't generation the Python's source code.

Do you test it ?

@laura-ding
Copy link
Contributor Author

@darionyaphet I have tested it, it can generate Python's source code. it should put ahead before generate go

dutor
dutor approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WellDone!
shelldont

darionyaphet
darionyaphet approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@darionyaphet darionyaphet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ! I tested it before but it didn't work.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Sep 9, 2019
@dutor dutor changed the title Add to build thrift py Generate python code from thrift Sep 9, 2019
@dutor dutor changed the title Generate python code from thrift Generate Python code from thrift Sep 9, 2019
@dutor dutor changed the title Generate Python code from thrift Generate thrift code for Python Sep 9, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit f585a7c into vesoft-inc:master Sep 9, 2019
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@laura-ding @dutor
Add build thrift py (vesoft-inc#891)
97ce226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutor dutor dutor approved these changes

@darionyaphet darionyaphet darionyaphet approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laura-ding @darionyaphet @nebula-community-bot @dutor