Let only successful run expire due to age #12237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mpolden please review. This fixes a problem where a NoSuchElementException was thrown when the only run was a success, this expired, and a new run failed. The solution is simply to throw away the success in this case, as we have no logs for it anyway
mpolden
approved these changes
Feb 18, 2020
| @Test | ||
| public void onlySuccessfulRunExpiresThenAnotherFails() { | ||
| DeploymentTester tester = new DeploymentTester(); | ||
| JobController jobs = tester.controller().jobController(); |
There was a problem hiding this comment.
To var or not to var, that is the question.
There was a problem hiding this comment.
Yeah, I'm not settled on that one yet :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mpolden please review.
This fixes a problem where a NoSuchElementException was thrown when the
only run was a success, this expired, and a new run failed.
The solution is simply to throw away the success in this case, as we
have no logs for it anyway