Add builder for ClusterSpec #12589
Merged
Add builder for ClusterSpec #12589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratseth
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
LGTM, and already an improvement so feel free to merge. The ClusterSpec is used either to request a desired cluster, or to specify an existing one (perhaps including group). I wonder if we couldn't keep the explicit separation between a request and the specification, like e.g replace "builder" by "request" and "specification" and have a boolean in the builder which only allows the correct fields for that context?
|
That separation was one of the things I wondered if we should somehow keep. Thanks for the suggestion, I'll look into it. |
request() should be used when requesting a cluster, same as old static method called request(). specification() should be used when creating a clsuter spec for an existing cluster, same as old static method from(). specification() will throw an exception if some required fields are not set
|
@bratseth please take a look again |
|
Great! You could also validate that a request don't set group (and vespa-version?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.