Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use number of cores to make a good assumption on number of threads to… #8494

Merged
merged 2 commits into from
Feb 13, 2019

Conversation

baldersheim
Copy link
Contributor

… use for content layer.
@vekterli PR

Copy link
Member

@vekterli vekterli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 content model changes look good to me. I don't have the deepest insight into the flavor and provisioning code, so someone else might want to take a look at those changes (@bratseth ?).

@vekterli
Copy link
Member

Travis failure:

[INFO] --- abi-check-plugin:7-SNAPSHOT:abicheck (default) @ config-provisioning ---
[ERROR] Class com.yahoo.config.provision.HostSpec: Extra method public void <init>(java.lang.String, java.util.List, com.yahoo.config.provision.Flavor)

Copy link
Member

@bratseth bratseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bratseth bratseth merged commit d33923d into master Feb 13, 2019
@bratseth bratseth deleted the balder/automatic-thread-config-if-flavor-is-known branch February 13, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants