Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow allocating to non-active hosts with dynamic provisioning #8743

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@freva
Copy link
Contributor

freva commented Mar 11, 2019

With dynamic provisioning, we can allocate a container to a host that already has node(s) by this tenant as long as that host is active. Because we prepare for each ClusterSpec separately, we will end up provisioning new hosts just for the logserver container, since any host just provisioned for a container/content node is still in provisioned. This PR relaxes that requirement:
For non-dynamic provisioning: No change (host must still be active)
For dynamic provisioning: Host can be any of provisioned, ready or active.

Not sure if this is possible, but ideally we should make sure that logserver is prepared last since it is most likely to be able to fit on any previously provisioned host.

@freva freva requested a review from hmusum Mar 11, 2019

@hmusum

hmusum approved these changes Mar 11, 2019

Copy link
Contributor

hmusum left a comment

LGTM.

FWIW, looks like AdminModel (which creates logserver) depends on ContainerModel and Content depends on both AdminModel and ContainerModel. So logserver will be prepared after container clusters, but before content clusters.

@hmusum hmusum changed the title Allow allocating to non-active hosts with dynamic provisioning Allow allocating to non-active hosts with dynamic provisioning Mar 12, 2019

@hmusum hmusum merged commit 4062663 into master Mar 12, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Merge Stop Enforcer Check preventing merges at merge stop.
cla/licenses User has a valid Oath CLA
Details

@hmusum hmusum deleted the freva/conservative-dynamic-provisioning branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.