Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication in subscription #40

Open
josephktcheung opened this issue Sep 11, 2018 · 0 comments
Open

Authentication in subscription #40

josephktcheung opened this issue Sep 11, 2018 · 0 comments

Comments

@josephktcheung
Copy link
Contributor

josephktcheung commented Sep 11, 2018 •
edited

In https://www.apollographql.com/docs/graphql-subscriptions/authentication.html, apollo suggests to use onConnect param to pass context specific data e.g. authenticating user over websocket. However, currently Vesper doesn't have a way to do that as the SubscriptionServer created by Vesper doesn't take any params to customise onConnect param.

@pleerock what do you think is the best way to handle this in Vesper not only for authentication but also other possible cases when we need to pass something into context in subscription?
josephktcheung added a commit to josephktcheung/vesper that referenced this issue Sep 11, 2018
@josephktcheung
Fix vesper-framework#40 add connectionParams to subscription context,…
24802b2 
… set context dataLoaders in subscribe resolver
@josephktcheung josephktcheung mentioned this issue Sep 11, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephktcheung