Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass basic auth settings in baseURL to xmlrpc lib #17

Merged
merged 2 commits into from
May 17, 2022

Conversation

aharter
Copy link
Contributor

@aharter aharter commented Jun 15, 2021

I also took the liberty to replace the legacy url.parse with the nodejs URL class.
This may or may not be a breaking change, since url.parse only throws a TypeError if the given URL is not a string. The URL class throws the error, if the input is not a valid URL.

See https://nodejs.org/api/url.html#url_new_url_input_base
and https://nodejs.org/api/url.html#url_url_parse_urlstring_parsequerystring_slashesdenotehost

@vettloffah
Copy link
Owner

Thanks for the PR - can you help me understand the basic auth feature. Why do we want / need it with the username and password params already included?

@aharter
Copy link
Contributor Author

aharter commented Jun 24, 2021

We have test instances exposed to the internet, which we protect from unwanted access using basic auth on the load balancer level.
First, I thought about adding the possibility to pass all client options available to the underlying xmlrpc (headers and cookies) to allow maximum flexibility. However, I opted for just the basic auth to keep it simple.

@vettloffah vettloffah merged commit 2cef252 into vettloffah:master May 17, 2022
@vettloffah vettloffah added the enhancement New feature or request label May 17, 2022
@vettloffah
Copy link
Owner

This has been published in version 3.2.0. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants