Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit Specifying and Listing Topics for Measure-Karma #101

Merged
merged 5 commits into from Nov 28, 2018

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Nov 28, 2018

  • Adds -ListTopics parameter to Measure-Koan which outputs a list of available koan topics
  • Adds -Topic parameter (string[]) that allows users to specify the koan topic(s) they wish to focus on
    • Values are autocompleted based on available koan files in $env:PSKoans_Folder

Resolves #99
Resolves #100

@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Module Pertaining to the module's functionality itself. labels Nov 28, 2018
@vexx32 vexx32 changed the base branch from master to 0.42.0 November 28, 2018 04:14
Copy link
Collaborator

@steviecoaster steviecoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks super solid. Merge it!

@vexx32 vexx32 merged commit 2463d72 into 0.42.0 Nov 28, 2018
@vexx32 vexx32 deleted the Measure-Karma_Topics branch November 28, 2018 15:53
@vexx32
Copy link
Owner Author

vexx32 commented Nov 28, 2018

❤️

vexx32 added a commit that referenced this pull request Dec 12, 2018
* Update Measure-Karma to support listing topics
Update Measure-Karma to support specifying topics to check

* Update meditation prompts to support specified topics

* Rename validator class for clarity

* Rename list switch for consistency

* Replace reference to old function name in Measure-Karma CBH
vexx32 added a commit that referenced this pull request Dec 13, 2018
* Update Measure-Karma to support listing topics
Update Measure-Karma to support specifying topics to check

* Update meditation prompts to support specified topics

* Rename validator class for clarity

* Rename list switch for consistency

* Replace reference to old function name in Measure-Karma CBH
vexx32 added a commit that referenced this pull request Dec 13, 2018
* Update Measure-Karma to support listing topics
Update Measure-Karma to support specifying topics to check

* Update meditation prompts to support specified topics

* Rename validator class for clarity

* Rename list switch for consistency

* Replace reference to old function name in Measure-Karma CBH
vexx32 added a commit that referenced this pull request Dec 14, 2018
* Update Measure-Karma to support listing topics
Update Measure-Karma to support specifying topics to check

* Update meditation prompts to support specified topics

* Rename validator class for clarity

* Rename list switch for consistency

* Replace reference to old function name in Measure-Karma CBH
vexx32 added a commit that referenced this pull request Dec 17, 2018
* Update Measure-Karma to support listing topics
- Update Measure-Karma to support specifying topics to check

* Update meditation prompts to support specified topics

* Rename validator class for clarity

* Rename list switch for consistency

* Replace reference to old function name in Measure-Karma CBH
vexx32 added a commit that referenced this pull request Dec 17, 2018
* Permit Specifying and Listing Topics for Measure-Karma (#101)

* Update Measure-Karma to support listing topics
- Update Measure-Karma to support specifying topics to check

* Update meditation prompts to support specified topics

* Rename validator class for clarity

* Rename list switch for consistency

* Replace reference to old function name in Measure-Karma CBH

* MODULE: Rename Write-MeditationPrompt to Show-MeditationPrompt
Retain old name as alias

* MODULE: Add Get/Set-PSKoanLocation cmdlets
- Use module-scoped variable instead of environment variable
- Add comment help to PSKoanLocation functions
- Replace references to module variable with get/set function
- Permit nonexistent paths for Set-PSKoanLocation
- Add KoanLocation functions to PSD1 exports

* MODULE: Add New-PSKoanErrorRecord & Improve topic searching
- Supports regex patterns
- Add New-PSKoanErrorRecord function for easy error record creation
- Other small changes

* MODULE: Rename module variables for clarity

* TEST: Remove unneeded test headers
- Invoke-Koan.Control_Tests
- Get-Blank.Tests

* MODULE/TEST: Refactor PSKoanLocation functions & add tests

TEST: Resolve remaining tests issues

TEST: Resolve outstanding issues with Measure-Karma tests
- Add tests for behaviour when koan library is empty/missing
MODULE: Ensure correct checking of total koans count

TEST: Use #Requires -Module for tests
- using module is not needed for module tests

* MODULE: Fix broken Get-Koan behaviour when using -Topic

* TEST: Finish adding Get-Koan Tests & fix #Requires declarations

* MODULE: Add [OutputType()] to module functions

* TEST: Preliminary tests for New-PSKoanErrorRecord

* STYLE: Add spacing between header and function declaration

* TEST: Complete New-PSKoanErrorRecord tests
- Fix issue with type check

* MODULE: Fix type name checking logic in New-PSKoanErrorRecord
- Use more robust test method for exception type

* TEST: Add test for Measure-Koan behaviour with -Topic param

* STYLE: Add final line terminator to script files

* BUILD: Restore working version of Publish.ps1

* STYLE: Consolidate style of comment-based help in module functions

* MODULE: Improve Advice frameworks
- Rename: Get-Advice -> Show-Advice
- Reformat advice data files into json with Title and Content
- Update Show-Advice and Write-ConsoleLine to handle title and contents.

* MODULE: Make topic parameters behave more consistently

* MODULE: Refactor Show-MeditationPrompt slightly

* MODULE: Update KoanAttribute to support module name

* MODULE: Update Register-Advice to use new cmdlet name in profile editing.
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Module Pertaining to the module's functionality itself.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants