Add Topic Selection support and Overhaul Tests #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vexx32
added
the
Category-Module
vexx32
force-pushed
the
0.42.0
branch
2 times, most recently
from
e8621f0
to
26fb11d
Compare
vexx32
added
PR-Needs-Review 🔍
vexx32
changed the title
steviecoaster
previously approved these changes
Dec 14, 2018
|
@steviecoaster If you have a few moments to check over the new stuff, I'd appreciate a second set of eyes before I put this into the master branch. 😄 |
vexx32
force-pushed
the
0.42.0
branch
2 times, most recently
from
a7c0e47
to
6d6d350
Compare
* Update Measure-Karma to support listing topics - Update Measure-Karma to support specifying topics to check * Update meditation prompts to support specified topics * Rename validator class for clarity * Rename list switch for consistency * Replace reference to old function name in Measure-Karma CBH
Retain old name as alias
- Use module-scoped variable instead of environment variable - Add comment help to PSKoanLocation functions - Replace references to module variable with get/set function - Permit nonexistent paths for Set-PSKoanLocation - Add KoanLocation functions to PSD1 exports
- Supports regex patterns - Add New-PSKoanErrorRecord function for easy error record creation - Other small changes
- Invoke-Koan.Control_Tests - Get-Blank.Tests
TEST: Resolve remaining tests issues TEST: Resolve outstanding issues with Measure-Karma tests - Add tests for behaviour when koan library is empty/missing MODULE: Ensure correct checking of total koans count TEST: Use #Requires -Module for tests - using module is not needed for module tests
- Fix issue with type check
- Use more robust test method for exception type
- Rename: Get-Advice -> Show-Advice - Reformat advice data files into json with Title and Content - Update Show-Advice and Write-ConsoleLine to handle title and contents.
steviecoaster
approved these changes
Dec 17, 2018
|
g2g |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get-Koancommand, with support for filtering returned koans based on a pattern.-Topicparameter toMeasure-Karma, permitting topic selection.Get-/Set-PSKoanlocationcommands, which permit the user to retrieve and set the stored koans folder location value.$env:PSKoans_Foldervariable; it will no longer be used.Write-MeditationPrompttoShow-MeditationPromptNew-PSKoanErrorRecordcommand as helper function to neatly construct error records.Invoke-KoanGet-PSKoanLocationandSet-PSKoanLocationNew-PSKoanErrorRecord-Topicparameter ofMeasure-KoanGet-Koan