Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog - Leave commits in order #314

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Changelog - Leave commits in order #314

merged 3 commits into from
Oct 29, 2019

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Oct 29, 2019

PR Summary

Having commits grouped by name is nice, but it's better to have it just in order I think.

Changes

  • Update GH username fetching to retry after a bit on failure.
  • Avoid grouping items, so we don't get the semi-sorting behaviour.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Build 🚀 Modifies the build / deployment system Category-Docs 📝 Pertaining to CBH, readme, other documentation labels Oct 29, 2019
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Oct 29, 2019
@vexx32 vexx32 merged commit 8e37746 into master Oct 29, 2019
@vexx32 vexx32 deleted the Changelog/FixSorting branch October 29, 2019 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Build 🚀 Modifies the build / deployment system Category-Docs 📝 Pertaining to CBH, readme, other documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant