feat: Add manila role #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okozachenko1203
force-pushed
the
add-manila-role
branch
from
5f7ce51
to
c342190
Compare
mnaser
requested changes
Mar 24, 2023
| oslo_messaging_notifications: | ||
| driver: noop | ||
|
|
||
| dependencies: |
There was a problem hiding this comment.
Shouldn’t this live in the Helm chart?
There was a problem hiding this comment.
well, i didn't make this as default in the chart and just commented with description.
There was a problem hiding this comment.
because users can select other driver types or even they can use share service without driver
okozachenko1203
force-pushed
the
add-manila-role
branch
from
c342190
to
dcb4022
Compare
okozachenko1203
force-pushed
the
add-manila-role
branch
from
dcb4022
to
1ea9035
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.