Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate go code and docker image configuration #386

Closed
remy-tiitre opened this issue Nov 28, 2017 · 6 comments
Closed

Separate go code and docker image configuration #386

remy-tiitre opened this issue Nov 28, 2017 · 6 comments

Comments

@remy-tiitre
Copy link

Have you thought about separating the docker-flow-proxy go code compilation and distribution from docker image. My issue is that I would like to use different base for docker-flow-proxy, alpines DNS causes issues and it would be easier to base the proxy image from our own corporate base image.

I know that we could do it right now as well, but we would have to fork the whole go source code as well, which is not ideal.

@vfarcic
Copy link
Owner

vfarcic commented Nov 29, 2017

Do you have a suggestion what would work well for your use case? Would publishing binaries separately from Docker images do the trick or you had something else in mind?

@remy-tiitre
Copy link
Author

Thats something I had in mind, yes. So I could base my docker image on centos, ubuntu or any other OS. There seems to be some issues with DNS configuration on alpine image. https://github.com/gliderlabs/docker-alpine/blob/master/docs/caveats.md

@vfarcic
Copy link
Owner

vfarcic commented Dec 3, 2017

I think I should have it done by the end of next week. I hope that's OK.

@remy-tiitre
Copy link
Author

Yeah, thats fine. Thanks for the greate work.

@vfarcic
Copy link
Owner

vfarcic commented Dec 9, 2017

I'll have to delay the work on this for a week. I had too much on my plate and could not find enough time.

vfarcic added a commit that referenced this issue Dec 16, 2017
vfarcic added a commit that referenced this issue Dec 17, 2017
Starting from this release, binaries will be attached to each. Fixes #386.[release]
@vfarcic
Copy link
Owner

vfarcic commented Dec 17, 2017

Available in the release https://github.com/vfarcic/docker-flow-proxy/releases/tag/17.12.17-87. Can you please try out the binaries and let me know if that's what you were looking for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants