Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return undefined when no point is found #11

Closed
wants to merge 1 commit into from
Closed

Return undefined when no point is found #11

wants to merge 1 commit into from

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

toPoint now returns a valid unist Point or undefined. This means the internal Point type is no longer used. The PointLike type was already unused.

Closes #10

@remcohaszing remcohaszing added 🧑 semver/major This is a change 🗄 area/interface This affects the public interface 🤞 phase/open Post is being triaged manually labels Mar 23, 2023
wooorm
wooorm approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but indeed, a major change!

@wooorm wooorm closed this in 4d67eb7 Jun 5, 2023
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added the 💪 phase/solved Post is done label Jun 5, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return undefined from toPoint if no match is found
3 participants
@remcohaszing @wooorm @ChristianMurphy