-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not showing the artist name on search of a song #1392
Comments
Also it won't show the duration of song. |
I have been using the same build of ViMusic for well over a year now (since it hasn't been updated on F-Droid since) and until just recently the search would always show the artist and play time for songs available on YouTube Music. Now it just shows the reduced information available for videos - this is not normal. YouTube probably changed their API for songs a bit and now the reverse-engineered InnerTube client falls back to its video parsing methods, which results in this misbehaviour. I'm going to look into this issue a bit myself, but, since I haven't worked with Android applications before and certainly none so complex, help from some of the more experienced developers out here would be amazing! Thanks in advance! PS: I also commented on the same issue for the RiMusic fork over here, but this is such relevant functionality that it should be fixed here too... |
Take a look at my pull request for RiMusic here for a really easy fix. |
Time Limited Forked Release of NeoMusic is here untill ViMusic gets a fresh breath of air, hopefully. Thanks @locxter for the fix & @vfsfitvnm for beautifully written code of this lightweight little gem of an app. |
So it's a fork of ViMusic. Is the only difference the fix? |
Fixes vfsfitvnm#1382. Fixes vfsfitvnm#1392. Fixes vfsfitvnm#1424. Fixes vfsfitvnm#1440. Fixes vfsfitvnm#1446.
…nm#1392 Author: locxter Co-Authored-By: Luca Schultz <54595101+locxter@users.noreply.github.com>
Steps to reproduce the bug
Go to search
Search for any song like despacito
Now it doesn't show the artist name in search screen
Expected behavior
This should show the artist name below the song title
Actual behavior
This only shows the song title and the artist name is null.
Screenshots/Screen recordings
Logs
No response
ViMusic version
0.5.4
Android version
Android 10
Additional information
Hope you will fix it soon .
The text was updated successfully, but these errors were encountered: