Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing the artist name on search of a song #1392

Open
mistrkrshna opened this issue Dec 23, 2023 · 5 comments
Open

Not showing the artist name on search of a song #1392

mistrkrshna opened this issue Dec 23, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@mistrkrshna
Copy link

Steps to reproduce the bug

Go to search
Search for any song like despacito
Now it doesn't show the artist name in search screen

Expected behavior

This should show the artist name below the song title

Actual behavior

This only shows the song title and the artist name is null.

Screenshots/Screen recordings

Screenshot_2023-12-23-10-20-49-484_it vfsfitvnm vimusic

Logs

No response

ViMusic version

0.5.4

Android version

Android 10

Additional information

Hope you will fix it soon .

@mistrkrshna mistrkrshna added the bug Something isn't working label Dec 23, 2023
@dreamAviator
Copy link

Also it won't show the duration of song.
Previously you could fix this by just searching again, but right now it's always lime this. IG youtube changes something?

@locxter
Copy link

locxter commented Dec 30, 2023

I have been using the same build of ViMusic for well over a year now (since it hasn't been updated on F-Droid since) and until just recently the search would always show the artist and play time for songs available on YouTube Music. Now it just shows the reduced information available for videos - this is not normal.

YouTube probably changed their API for songs a bit and now the reverse-engineered InnerTube client falls back to its video parsing methods, which results in this misbehaviour. I'm going to look into this issue a bit myself, but, since I haven't worked with Android applications before and certainly none so complex, help from some of the more experienced developers out here would be amazing!

Thanks in advance!

PS: I also commented on the same issue for the RiMusic fork over here, but this is such relevant functionality that it should be fixed here too...

This was referenced Dec 30, 2023
@locxter
Copy link

locxter commented Dec 30, 2023

Take a look at my pull request for RiMusic here for a really easy fix.

ShareASmile added a commit to ShareASmile/ViMusic that referenced this issue Dec 31, 2023
…nm#1392

Note by @locxter - After removing and readding songs to a playlist, since it was already stored with the null bug before. Users affected by this issues have to erase their database

Co-Authored-By: Luca Schultz <54595101+locxter@users.noreply.github.com>
@ShareASmile
Copy link

Time Limited Forked Release of NeoMusic is here untill ViMusic gets a fresh breath of air, hopefully.

Thanks @locxter for the fix & @vfsfitvnm for beautifully written code of this lightweight little gem of an app.

@dreamAviator
Copy link

So it's a fork of ViMusic. Is the only difference the fix?

taylordotfish added a commit to taylordotfish/ViMusic that referenced this issue Jan 27, 2024
ShareASmile added a commit to ShareASmile/ViMusic that referenced this issue Feb 19, 2024
…nm#1392

Author: locxter
Co-Authored-By: Luca Schultz <54595101+locxter@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants