Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Proxy support #1089

Closed
wants to merge 7 commits into from
Closed

Added Proxy support #1089

wants to merge 7 commits into from

Conversation

SuhasDissa
Copy link

Hey there!

I really like your app, but unfortunately I've had to use it with a VPN because YouTube Music isn't supported in my country. I thought it would be helpful to add proxy support to your app, so I did! I hope you like it.

I tested it out and everything seems to be working properly.
I added a settings item to edit proxy settings, but it's not the most elegant thing ever 馃槄.
I'll work on improving it in the future.

@vfsfitvnm
Copy link
Owner

Thanks for this valuable PR!

ViMusic needs a severe rewrite and redesign (in all three UI, UX and SW), and unfortunately I'm not planning to do it anytime soon.
I don't feel confident in adding a new feature and release a new version out of the blue; and as a single developer, it's unlikely I will merge this PR for now, I apologize.

At least, people who absolutely need this feature can build the app themselves.

I'm going to do a blind-review to your changes anyway, you dedicated effort and time in that, and, sadly, a review is the only "reward" I can offer.

@SuhasDissa
Copy link
Author

No worries. I also believe that a redesign is a good idea.
Thanks for your review. And also for this great app. 馃槂

@vfsfitvnm vfsfitvnm mentioned this pull request Jun 13, 2023
Closed
@SuhasDissa
Copy link
Author

If you want me to fix the typos then I can do it before any merging

@SuhasDissa
Copy link
Author

SuhasDissa commented Jun 13, 2023

Here are some screenshots for reference

@royal-crisis
Copy link

@SuhasDissa would you mind sharing your build i.e APK file

@SuhasDissa
Copy link
Author

Hi there!

I'm sorry to say that I don't have the original key file to build a signed APK. This means that I can only build debug APKs, which are not suitable for release.

I don't want to redistribute this app with my own signature without vfsfitvnm's permission.

I hope you understand.
Thanks.

@SuhasDissa SuhasDissa closed this by deleting the head repository Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants