Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in control.py #18

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Bug in control.py #18

merged 1 commit into from
Mar 10, 2024

Conversation

sam-scale
Copy link
Contributor

If model has an attribute called model, then you should get the layers via model.model.layers not model.layers

If `model` has an attribute called `model`, then you should get the layers via `model.model.layers` not `model.layers`
@sam-scale
Copy link
Contributor Author

Hey @vgel let me know what you think!

@vgel
Copy link
Owner

vgel commented Mar 10, 2024

You're completely right, thank you! I really need to get a Mistral-architecture model in CI 😅

@vgel vgel self-requested a review March 10, 2024 07:22
@vgel
Copy link
Owner

vgel commented Mar 10, 2024

Fixes #16

@vgel vgel linked an issue Mar 10, 2024 that may be closed by this pull request
@vgel vgel merged commit 34e363e into vgel:main Mar 10, 2024
3 checks passed
@vgel vgel mentioned this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when running honesty.ipynb
2 participants