Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log a warning when parsing of the config file has failed #66

Merged
merged 2 commits into from Feb 15, 2018
Merged

Log a warning when parsing of the config file has failed #66

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9b37f4
Log a warning when parsing of the config file failed
talkrz Feb 13, 2018
a1cc276
Instead of warning terminate the app when config file is invalid
talkrz Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/SSEConfig.cpp
View file
Open in desktop
Expand Up @@ -70,7 +70,9 @@ bool SSEConfig::load(const char *file) {
// Read config file.
try {
boost::property_tree::read_json(file, pt);
} catch (...) {}
} catch (boost::property_tree::ptree_error& e) {
LOG(WARNING) << "Error during loading config file: " << e.what();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps log FATAL instead of WARNING? It shouldn't be able to start up at all without a proper config.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing, this is absolutely a check we should have. I agree with @sgulseth regarding that it should be a FATAL and not a warning. Add in that and I will merge the PR!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've changed it to FATAL and now the app doesn't start when config is not parsed or not present. Thanks for your feedback.

}

// Populate ConfigMap.
BOOST_FOREACH(ConfigMap_t::value_type &element, ConfigMap) {
Expand Down