Marker obj and door opening for simple animals (currently only necromorphs) #10742

gbasood · 2016-06-24T01:40:39Z

Welcome to a really silly PR
Adds a marker object, which spawns xenomorphs out of people when it's anchored and they touch it with hands OR someone drags them onto it
Also the marker whispers periodically.

Also adds a flag that lets simple animals (currently only necromorphsmorphs) open doors when a player controlling them clicks on them or bumps them.

Things that would be cool to add but that I don't feel like doing because I'm tired as fuck:

Recruitment for necromorphs made without clients
Animated icon for marker instead of just glowing red while anchored
Hivespeak for necromorphs

Also NOT TESTED

…rphs)

gbasood · 2016-06-24T01:45:47Z

code/game/machinery/doors/firedoor.dm

@@ -267,9 +270,6 @@ var/global/list/alert_overlays_global = list()
 		if(check_access(ID))
 			access_granted = 1

-	var/answer = "Yes"
-	if(answer == "No")
-		return


Also I found this gem.
Seriously why does this exist

Probably put it in the wrong file and left it unfinished, it reminds me of the AI warning when it attempts to force open a firedoor.

Looks like something that used to be an input.

gbasood · 2016-06-24T02:46:50Z

I moved the file so the diff changed
@skullyton What's up with the gibbing and mindswapping? Say it out of the diff so I don't lose it

ghost · 2016-06-24T02:58:52Z

Basically, at least what I've seen with how a staff of necromancy does it, if you hit a dead guy whose mind is still in the brain, it'll gib and attempt to transfer, but then they're caught in limbo between the head/brain and in the zombie.

gbasood · 2016-06-24T03:00:41Z

note to self
test
also use mind.transfer_to

ghost · 2016-06-24T03:28:29Z

It gets weirder when the zombie is killed, and somebody attempts to soul shard the head

Intigracy · 2016-06-27T02:06:31Z

code/modules/research/xenoarchaeology/artifact/artifact_necromarker.dm

+
+    var/ticks_not_whispered = 0
+    var/next_whisper = 300
+    var/whispers = list("...bring me flesh...", "...make us whole...", "...we must be whole...", "...join us in unity...", "...one mind, one soul, one flesh...", "...MAKE US WHOLE...")


shouldn't this be "bring us flesh" to keep in the same tune as the rest of the whispers?

yes actually

Intigracy · 2016-06-27T02:10:07Z

I don't really see anything else past my two comments.

gbasood · 2016-06-28T15:34:00Z

🍆

PJB3005 · 2016-06-28T20:04:18Z

code/modules/research/xenoarchaeology/artifact/artifact_necromarker.dm

+        visible_message("[pick(whispers)]")
+        next_whisper = rand(NECROMARKER_MIN_WHISPER_INTERVAL, NECROMARKER_MAX_WHISPER_INTERVAL)
+    else
+        ticks_not_whispered++


Should be using world time timestamps.

PJB3005 · 2016-06-28T20:06:24Z

code/modules/research/xenoarchaeology/artifact/artifact_necromarker.dm

+                    break
+                else
+                    candidates -= O
+        visible_message("<span class='warning'>[src] spins the flesh and bone of [M] into a hellish monstrosity!</span>")


Should have \the

Isn't \the automatically added by BYOND when you use [src] (rather than [src.name])?

Should still use \the IMO.

Exxion, no, it's not.

If [src] is capitalized then it won't add a the automatically, it only adds the automatically to \improper named objects (which is automatically true if the word isn't capitalized).

That's exactly how \the works anyway.

That's wrong, though.
I just tested it.

There would be no point to \the acting the way you said, as it would be the same as just writing "the"

Which part is wrong?

That I was wrong.
\the behaves as I said
It does not show up before things counted as proper nouns

Oh I see pictures now, didn't when I was on my phone.

Just tested myself too, I guess I was wrong.

Does \the even have a use then? I always figured it was just a failsafe and would add a the unless one was being automatically added due to improper nounage.

Using "The [src]" makes it turn into The the light replacer.

\the is only automatically inserted if you put the object reference in directly, so [src] or something similar
NOT if you put in [src.name], etc.

PJB3005 · 2016-06-28T20:07:27Z

code/modules/research/xenoarchaeology/artifact/artifact_necromarker.dm

+                if(O && O.mind && O.ckey)
+                    O.mind.transfer_to(Z)
+                    Z.ckey = O.ckey // Because ghosts don't get key changes
+                    candidates -= O


This line is copy pasted below, put it outside the if and remove copy paste + else clause.

PJB3005 · 2016-06-28T20:08:12Z

This is why we don't self merge.

PJB3005 · 2016-06-28T20:08:49Z

code/modules/research/xenoarchaeology/artifact/artifact_necromarker.dm

+            log_game("[user]/[user.ckey] forcefully turned [M]/[M.ckey] into a necromorph.")
+        else
+            message_admins("[M]/[M.ckey] turned into a necromorph via a marker. (<A HREF='?_src_=holder;adminplayerobservecoodjump=1;X=[loc.x];Y=[loc.y];Z=[loc.z]'>JMP</A>)")
+            log_game("[M]/[M.ckey] turned into a necromorph.")


PJB3005 · 2016-06-28T20:11:39Z

👏

gbasood · 2016-06-28T20:29:03Z

as I've said elsewhere before the revert came up
I made this as a small feature and I didn't intend to make it anything more than it was
If someone wants to address the issues raised and add on this then by all means go for it
I don't intend to put more work into it

ghost · 2016-06-28T20:31:10Z

After seeing it live

Both the dragger and the dragged need to be next to the marker for some reason
For some reason, it needs to be anchored like a machine, making dropping one in needing some preperation in wrenching it.
Necromorphs are slow, take about 5 shots from any sort of laser to kill, and take too long to regenerate to be of any use (sorry, my fault)
Necromorphs can't open doors that they don't have access to, meaning people can just run into maint and be safe, you'd think they'd be able to pull a door apart like any giant spider can

gbasood · 2016-06-28T20:37:03Z

I also opened some other issues related to that round
#10822
#10821
#10820
#10819
#10818

Mostly just ideas, none of them fully necessary

Intigracy · 2016-06-28T20:51:12Z

You should re-add the door opening seperately at least

Marker obj and door opening for simple animals (currently only xenomo…

080f9fa

…rphs)

gbasood added Content Adds something. Neat! Needs Review labels Jun 24, 2016

gbasood changed the title ~~Marker obj and door opening for simple animals (currently only xenomo…~~ Marker obj and door opening for simple animals (currently only necromorphs) Jun 24, 2016

gbasood reviewed Jun 24, 2016
View reviewed changes

gbasood added 2 commits June 26, 2016 15:16

typo fixes, changelog

0dae572

more fixing, observer signup

6a50eaa

gbasood removed the Needs Changelog label Jun 27, 2016

fin

eb0f46e

gbasood added Needs Final Decision and removed Needs Review labels Jun 27, 2016

fin really

8c6d325

Intigracy reviewed Jun 27, 2016
View reviewed changes

gbasood added 2 commits June 27, 2016 08:35

objective complete, payload secured

e961efb

whoops

27720b1

gbasood merged commit 0b38588 into vgstation-coders:Bleeding-Edge Jun 28, 2016

PJB3005 reviewed Jun 28, 2016
View reviewed changes

ComicIronic mentioned this pull request Jun 28, 2016

Revert "Marker obj and door opening for simple animals (currently only necromorphs)" #10828

Merged

PJB3005 reviewed Jun 28, 2016
View reviewed changes

ghost mentioned this pull request Feb 1, 2017

Adds custom artifact creation. Adds the dead harvest artifact effect #13751

Merged

gbasood mentioned this pull request Feb 9, 2017

(WIP) Necromorph marker redux #13900

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Marker obj and door opening for simple animals (currently only necromorphs) #10742

Marker obj and door opening for simple animals (currently only necromorphs) #10742

gbasood commented Jun 24, 2016 •

edited

gbasood Jun 24, 2016

Intigracy Jun 24, 2016 •

edited

ComicIronic Jun 24, 2016

gbasood commented Jun 24, 2016

ghost commented Jun 24, 2016 •

edited by ghost

gbasood commented Jun 24, 2016

ghost commented Jun 24, 2016

Intigracy Jun 27, 2016

gbasood Jun 27, 2016

Intigracy commented Jun 27, 2016

gbasood commented Jun 28, 2016

PJB3005 Jun 28, 2016

PJB3005 Jun 28, 2016

Exxion Jun 28, 2016 •

edited

PJB3005 Jun 28, 2016

Intigracy Jun 28, 2016 •

edited

Exxion Jun 28, 2016

Exxion Jun 28, 2016 •

edited

Intigracy Jun 29, 2016 via email

Exxion Jun 29, 2016

Intigracy Jun 29, 2016

Exxion Jun 29, 2016

PJB3005 Jun 28, 2016

PJB3005 commented Jun 28, 2016

PJB3005 Jun 28, 2016

PJB3005 commented Jun 28, 2016

gbasood commented Jun 28, 2016

ghost commented Jun 28, 2016

gbasood commented Jun 28, 2016 •

edited

Intigracy commented Jun 28, 2016

Marker obj and door opening for simple animals (currently only necromorphs) #10742

Marker obj and door opening for simple animals (currently only necromorphs) #10742

Conversation

gbasood commented Jun 24, 2016 • edited

Choose a reason for hiding this comment

Intigracy Jun 24, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gbasood commented Jun 24, 2016

ghost commented Jun 24, 2016 • edited by ghost

gbasood commented Jun 24, 2016

ghost commented Jun 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Intigracy commented Jun 27, 2016

gbasood commented Jun 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Exxion Jun 28, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Intigracy Jun 28, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Exxion Jun 28, 2016 • edited

Choose a reason for hiding this comment

Intigracy Jun 29, 2016 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PJB3005 commented Jun 28, 2016

Choose a reason for hiding this comment

PJB3005 commented Jun 28, 2016

gbasood commented Jun 28, 2016

ghost commented Jun 28, 2016

gbasood commented Jun 28, 2016 • edited

Intigracy commented Jun 28, 2016

gbasood commented Jun 24, 2016 •

edited

Intigracy Jun 24, 2016 •

edited

ghost commented Jun 24, 2016 •

edited by ghost

Exxion Jun 28, 2016 •

edited

Intigracy Jun 28, 2016 •

edited

Exxion Jun 28, 2016 •

edited

gbasood commented Jun 28, 2016 •

edited