New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Necromorph marker redux #13900
(WIP) Necromorph marker redux #13900
Conversation
else if(isanimal(user)) | ||
var/mob/living/simple_animal/SA = user | ||
if(SA.can_force_doors) | ||
open() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to change this up, as right now it means the big thing with scary claws can open a door instantly, but also can be locked down via door bolts.
Maybe rather than having can_force_doors act as a boolean, have it variable, with 1 being can open doors after some time but not bolted doors, 2 being can open doors that are bolted/welded/jammed, but it takes a bit of time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm changing it on airlocks right now but the base door
type applies to non-airlocks as well, so this block will stay as is
|
hahah it's the first PR all over again |
74e4e86
to
c43de27
Compare
shock(user, 100) | ||
if(istype(user, /mob/living/simple_animal)) | ||
var/mob/living/simple_animal/SA = user | ||
if(locked || welded || jammed || SA.can_force_doors != 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's locked, welded, jammed, or can_force_doors does not equal two, return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops
I meant to change this
var/mob/living/simple_animal/SA = user | ||
if(locked || welded || jammed || SA.can_force_doors != 2) | ||
to_chat(user, "<span class='notice'>The airlock won't budge!</span>") | ||
else if (SA.can_force_doors > 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, if can_force_doors > 0
More work when? |
One day. |
I'm gonna try to work on this bit by bit over time
I'm probably gonna have to revisit how some things work entirely to make them not shit, which is part of the reason I'm putting this up
The other part is so there's as much time to review my shitcode as possible before I feel it's "done"
Original pr is #10742
TODO:
Also todo although I think some of this might have been fixed since:
#10818
#10819
#10820
#10821
#10822