Allow gyrotron controller to be buffered #16193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJB3005
suggested changes
Oct 7, 2017
| @@ -72,6 +72,16 @@ | |||
| </ul> | |||
| "} | |||
|
|
|||
| /obj/machinery/rust/gyrotron/canLink(var/obj/machinery/computer/rust_gyrotron_controller/object, var/link/context) | |||
| . = (istype(object) && get_dist(src, object) < RUST_GYROTRON_RANGE) | |||
There was a problem hiding this comment.
Use return, it's much more readable.
There was a problem hiding this comment.
Once this is fixed I'll merge. Tiny thing but it makes a difference.
| /obj/machinery/computer/rust_gyrotron_controller | ||
| name = "Gyrotron Remote Controller" | ||
| icon_state = "engine" | ||
| circuit = /obj/item/weapon/circuitboard/rust_gyrotron_control | ||
| light_color = LIGHT_COLOR_BLUE | ||
|
|
||
| var/id_tag // Required for multitool buffering |
There was a problem hiding this comment.
Uh, is it actually? If it is then you should fix that instead.
There was a problem hiding this comment.
Indeed, I don't really want to do it right now, though.
| @@ -0,0 +1 @@ | |||
| #undef RUST_GYROTRON_RANGE | |||
N3X15
added
Needs Fixing
鉂わ笍 Quality of Life 鉂わ笍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes .1 of #16190
馃啈