Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

R-UST fuel injector overhaul #16194

Merged
merged 1 commit into from Oct 8, 2017

Conversation

DamianX
Copy link
Contributor

@DamianX DamianX commented Oct 8, 2017

Needs changelog, wiki update, testing of the fuel port.
Tested.
Addresses some of #16190

it's mostly a UI/QoL + code style change, with the core functionality staying intact

image

馃啈

  • tweak: The R-UST fuel injector no longer requires cable coils in construction. It can now be deconstructed, and its circuit board is available from the circuit imprinter.
  • tweak: The R-UST fuel injector has a new UI.

@DamianX DamianX changed the title [WIP] R-UST fuel injector overhaul R-UST fuel injector overhaul Oct 8, 2017
@Kurfursten
Copy link
Collaborator

What do you know, there was a build recipe after all. It just wasn't in constructable_frame for reasons unknown.

For maintainability it might be best to kill Rust/circuits and move those to the rest of the designs

@Kurfursten
Copy link
Collaborator

As a reminder, under boards/machine_engie.dm, look up the /datum/design/rust_injector

It builds the wrong board

@DamianX
Copy link
Contributor Author

DamianX commented Oct 8, 2017

But this PR addresses that?

@Kurfursten
Copy link
Collaborator

I missed that file change. 馃憤

@ghost
Copy link

ghost commented Oct 8, 2017

god bless, i remember the pain of convincing R&D i needed specific parts for the R-UST machines one round, it was faster to just order the things

the new UI is good too, the old one was a bit ech

@N3X15 N3X15 merged commit 890d064 into vgstation-coders:Bleeding-Edge Oct 8, 2017
@DamianX DamianX deleted the RustIssues2 branch March 2, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants