Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Opensoure.org from Link Check #381

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Ignore Opensoure.org from Link Check #381

merged 1 commit into from
Dec 1, 2022

Conversation

brian926
Copy link
Contributor

Closes #375

This looks to be an issue with markdown-link-check and sites that use DoS & Spam protection. Currently, there are two open issues in markdown-link-check in regards to this where sites like Amazon, GoDaddy, Cloudfare, etc. are all reachable but return a 500 error when checked.
Markdown-link-check issue #109
Markdown-link-check issue #23

Added Opensource.org to be ignored, it's not a great solution but it helps to stop false negatives. I hope this helps with some of the legwork!

@alannair
Copy link
Collaborator

Hi @brian926. Thanks for this PR. It does indeed fix the Link-Check problem.
However, may I make one request - It looks like Commit-Lint fails on your PR. This is because you have not signed your commits.
It would be great if you could sign your commit as git commit -s -m "COMMIT MESSAGE". No need for gpg sign (i.e. -S), just the signoff (-s) is enough.
Also, you could take the opportunity to remove the redundant commits. Five commits for a one-line change seems a bit much :)

$ git reset main~5    # on your local branch undo the last 5 commits
$ git stage .  # stage all those changes (which got uncommitted by the last step)
$ git commit -s -m "COMMIT MESSAGE"   # now commit all those changes as a single signed commit
$ git push --force origin   # force push to your remote github repository - overwrites the 5 commits as a single one (change remote name if its not origin).

Thank you so much for your efforts!

Signed-off-by: Brian Antunes <brian.antunes@yahoo.com>
@brian926
Copy link
Contributor Author

@alannair sorry about that!! Just ran those commands, removed the excess commits, and signed.

@alannair alannair merged commit 1aabd77 into vhive-serverless:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter Link-Check Fails
2 participants