Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add encoding parameter to add_keyword_from_file() #40

Closed
wants to merge 1 commit into from

Conversation

liacoponi
Copy link

@liacoponi liacoponi commented Dec 15, 2017

It would be useful to specify the encoding of the file in the add_keywords_from_file. Passing **kwargs seem an overkill since no other parameter is useful for parsing the file.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.298% when pulling 0d9a296 on liacoponi:patch-1 into 1c970b5 on vi3k6i5:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.298% when pulling 0d9a296 on liacoponi:patch-1 into 1c970b5 on vi3k6i5:master.

@vi3k6i5
Copy link
Owner

vi3k6i5 commented Jan 26, 2018

Travis CI build was failing because code changes were not compatible with python 2.6, hence changed the approach for getting encoding parameter using

with io.open(keyword_file, encoding=encoding) as f:

Instead of jsut open(

Still thanks for the pull request 👍

@vi3k6i5 vi3k6i5 closed this Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants