Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(arc-1566): force month selection arrows to be displayed #751

Closed
wants to merge 2 commits into from
Closed

fix(arc-1566): force month selection arrows to be displayed #751

wants to merge 2 commits into from

Conversation

bertyhell
Copy link
Contributor

@bertyhell bertyhell commented Mar 28, 2023 •
edited
Loading

@bertyhell bertyhell requested review from a user, tourlbr and WardVerc1 March 28, 2023 17:54
ghost
ghost suggested changes Mar 29, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fixed on the alerts forms but I don't think we always need to add the flex styling because it breaks the styling the other datepickers:
image

@tourlbr
Copy link
Contributor

tourlbr commented Mar 29, 2023

Shouldn't we just show the same options as on the datepicker shown in Silke her screenshot? Instead of the arrows?

@bertyhell bertyhell marked this pull request as draft March 31, 2023 11:52
@bertyhell
Copy link
Contributor Author

replaced with admin-core PR: viaacode/react-admin-core-module#149

@bertyhell bertyhell closed this Mar 31, 2023
@bertyhell bertyhell deleted the bugfix/ARC-1566-date-picker-month-selection-arrows branch April 21, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tourlbr tourlbr Awaiting requested review from tourlbr

@WardVerc1 WardVerc1 Awaiting requested review from WardVerc1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertyhell @tourlbr