-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotdox Support #732
Hotdox Support #732
Conversation
…lt bootloader.Disabled the following via ifdef and rules.mk: backlight, rgb lighting.
the default keymap fails to build |
Sorry about that. I seemed to have switched BACKLIGHT_ENABLE and RGBLIGHT_ENABLE around. That's what I get for 1am commits. I have updated the hotdox.c and vial/keymap.c files to use the BACKLIGHT_ENABLE value instead of the RGBLIGHT_ENABLE. I have confirmed that the default keymap now builds.
|
why are you removing the VIA keymap and changing common files, the PR should only touch vial keymap ideally to prevent future merge conflicts |
When I created the pull request there was a list of actions to take prior to submission prefilled in the pull request description. IIRC removing the via keymap was one so I did as instructed. I need to change common files due to the storage limitation of the mcu in the hotdox. If it's not suitable to merge that's fine. Feel free to close. |
This PR adds support for the Alpacalabs Hotdox keyboard.
Due to the limited storage in the MCU on the Hotdox I did have to modify the
hotdox.c
file to add ifdefs to optionally remove backlight and RGB control. This can be re-enabled via values inrules.mk
if other features are disabled.I have confirmed that this configuration works as expected on my v1 Hotdox.