Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotdox Support #732

Closed
wants to merge 11 commits into from
Closed

Hotdox Support #732

wants to merge 11 commits into from

Conversation

Smurf
Copy link

@Smurf Smurf commented May 17, 2024

This PR adds support for the Alpacalabs Hotdox keyboard.

Due to the limited storage in the MCU on the Hotdox I did have to modify the hotdox.c file to add ifdefs to optionally remove backlight and RGB control. This can be re-enabled via values in rules.mk if other features are disabled.

I have confirmed that this configuration works as expected on my v1 Hotdox.

@xyzz
Copy link
Contributor

xyzz commented May 21, 2024

the default keymap fails to build

@Smurf
Copy link
Author

Smurf commented May 21, 2024

Sorry about that. I seemed to have switched BACKLIGHT_ENABLE and RGBLIGHT_ENABLE around. That's what I get for 1am commits.

I have updated the hotdox.c and vial/keymap.c files to use the BACKLIGHT_ENABLE value instead of the RGBLIGHT_ENABLE.

I have confirmed that the default keymap now builds.

$ make hotdox:default                                                                   
Making hotdox with keymap default

avr-gcc (Fedora 13.2.0-1.fc38) 13.2.0
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Size before:
   text	   data	    bss	    dec	    hex	filename
      0	  24774	      0	  24774	   60c6	hotdox_default.hex

Compiling: quantum/keymap_introspection.c                                                           [OK]
Linking: .build/hotdox_default.elf                                                                  [OK]
Creating load file for flashing: .build/hotdox_default.hex                                          [OK]
Copying hotdox_default.hex to qmk_firmware folder                                                   [OK]
Checking file size of hotdox_default.hex                                                            [OK]
 * The firmware size is fine - 24774/28672 (86%, 3898 bytes free)

@xyzz
Copy link
Contributor

xyzz commented Jun 23, 2024

why are you removing the VIA keymap and changing common files, the PR should only touch vial keymap ideally to prevent future merge conflicts

@Smurf
Copy link
Author

Smurf commented Jun 24, 2024

why are you removing the VIA keymap and changing common files, the PR should only touch vial keymap ideally to prevent future merge conflicts

When I created the pull request there was a list of actions to take prior to submission prefilled in the pull request description. IIRC removing the via keymap was one so I did as instructed.

I need to change common files due to the storage limitation of the mcu in the hotdox.

If it's not suitable to merge that's fine. Feel free to close.

@xyzz xyzz closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants