Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP-4882] - get toast message to truncate when overflowing #535

Merged

Conversation

jgeaso1266
Copy link
Contributor

@jgeaso1266 jgeaso1266 commented Jul 1, 2024

Description

This PR adds truncation to the text of a toast.

image

Note: this change is possible as all of the toast verbiage has the format "{action} {name}", like "created test" or "renamed test". So there will be no issues with the action being cut off at the end.

@jgeaso1266 jgeaso1266 requested review from anjinai and mcous July 1, 2024 17:56
@jgeaso1266 jgeaso1266 marked this pull request as ready for review July 1, 2024 17:59
@jgeaso1266 jgeaso1266 requested a review from mcous July 1, 2024 19:27
@jgeaso1266 jgeaso1266 requested a review from mcous July 2, 2024 02:20
Copy link
Contributor

@anjinai anjinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jgeaso1266 jgeaso1266 merged commit 23ef504 into viamrobotics:main Jul 3, 2024
4 checks passed
@jgeaso1266 jgeaso1266 deleted the APP-4882-toast-text-should-wrap branch July 3, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants