APP-4665 collapse cloud-build logs (#3820)

viamrobotics · Apr 17, 2024 · f355349 · f355349
1 parent 513136a
commit f355349
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 7 deletions.
diff --git a/cli/app.go b/cli/app.go
@@ -49,13 +49,14 @@ const (
 	moduleFlagForce           = "force"
 	moduleFlagBinary          = "binary"
 
-	moduleBuildFlagPath     = "module"
-	moduleBuildFlagRef      = "ref"
-	moduleBuildFlagCount    = "count"
-	moduleBuildFlagVersion  = "version"
-	moduleBuildFlagBuildID  = "id"
-	moduleBuildFlagPlatform = "platform"
-	moduleBuildFlagWait     = "wait"
+	moduleBuildFlagPath      = "module"
+	moduleBuildFlagRef       = "ref"
+	moduleBuildFlagCount     = "count"
+	moduleBuildFlagVersion   = "version"
+	moduleBuildFlagBuildID   = "id"
+	moduleBuildFlagPlatform  = "platform"
+	moduleBuildFlagWait      = "wait"
+	moduleBuildFlagGroupLogs = "group-logs"
 
 	mlTrainingFlagPath      = "path"
 	mlTrainingFlagName      = "name"
@@ -1373,6 +1374,10 @@ Example:
 									Name:  moduleBuildFlagWait,
 									Usage: "wait for the build to finish before outputting any logs",
 								},
+								&cli.BoolFlag{
+									Name:  moduleBuildFlagGroupLogs,
+									Usage: "write ::group:: commands so github action logs collapse",
+								},
 							},
 							Action: ModuleBuildLogsAction,
 						},

diff --git a/cli/module_build.go b/cli/module_build.go
@@ -3,6 +3,7 @@ package cli
 import (
 	"fmt"
 	"io"
+	"os"
 	"strings"
 	"text/tabwriter"
 	"time"
@@ -192,6 +193,7 @@ func ModuleBuildLogsAction(c *cli.Context) error {
 	buildID := c.String(moduleBuildFlagBuildID)
 	platform := c.String(moduleBuildFlagPlatform)
 	shouldWait := c.Bool(moduleBuildFlagWait)
+	groupLogs := c.Bool(moduleBuildFlagGroupLogs)
 
 	client, err := newViamClient(c)
 	if err != nil {
@@ -216,11 +218,24 @@ func ModuleBuildLogsAction(c *cli.Context) error {
 		}
 		var combinedErr error
 		for _, platform := range platforms {
+			if groupLogs {
+				statusEmoji := "❓"
+				switch statuses[platform] { //nolint: exhaustive
+				case jobStatusDone:
+					statusEmoji = "✅"
+				case jobStatusFailed:
+					statusEmoji = "❌"
+				}
+				printf(os.Stdout, "::group::{%s %s}", statusEmoji, platform)
+			}
 			infof(c.App.Writer, "Logs for %q", platform)
 			err := client.printModuleBuildLogs(buildID, platform)
 			if err != nil {
 				combinedErr = multierr.Combine(combinedErr, client.printModuleBuildLogs(buildID, platform))
 			}
+			if groupLogs {
+				printf(os.Stdout, "::endgroup::")
+			}
 		}
 		if combinedErr != nil {
 			return combinedErr