Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-4665 collapse cloud-build logs #3820

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

abe-winter
Copy link
Member

@abe-winter abe-winter commented Apr 17, 2024

What changed

  • add --group-logs param to ModuleBuildLogsAction
  • when present, this flag adds a ::group:: wrapper to each platform in the logs output
  • should match expected format in their docs here

Why

Currently, when multiple platforms are present in this output, it's difficult to read the logs. When one of them fails, it's difficult to know which.

Example output

::group::{✅ linux/amd64}
Info: Logs for "linux/amd64"
Info: viam version
...
Total size uploaded: 1.7 KiB
::endgroup::

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Apr 17, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 17, 2024
zaporter-work
zaporter-work approved these changes Apr 17, 2024
@abe-winter abe-winter merged commit f355349 into viamrobotics:main Apr 17, 2024
16 checks passed
@abe-winter abe-winter deleted the group-build-logs branch April 17, 2024 21:11
vijayvuyyuru pushed a commit to vijayvuyyuru/rdk that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants