-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-2482: add rc card for encoder #2230
Conversation
the actual changes only display up to 2 decimal places unlike what's shown in the image in the description |
@martha-johnston We just updated the other cards to a new border color in this PR, could you replicate those changes here? 🙏 |
will do! does this also mean I need to bump my remote-control version to 2.17? |
I did but I can change it back if I shouldn't have |
You'll actually need to bump the main |
e22a71c
to
5a78d84
Compare
|
This change adds an RC card for the new encoder API. If the encoder only supports ticks, only the
Count
column will be shown, and if it only supports degrees, only theAngle (degrees)
column will be shown. If the encoder supports both, then both columns will be there, as shown in the image below.Note: The reset functionality is not currently working for the AMS encoders. I believe this is not a frontend issue, but a driver issue, which I will be investigating shortly.