Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix border color #2243

Merged
merged 4 commits into from Apr 19, 2023
Merged

Bug fix border color #2243

merged 4 commits into from Apr 19, 2023

Conversation

mrloureed
Copy link
Member

This updates the RDK style to match the latest APP style.
FYI @nathartman @micheal-parks

Bug:
image

Fix:
image

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Apr 18, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 18, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 18, 2023
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 64% 0.00% ➖
go.viam.com/rdk/components/arm/fake 31% 0.00% ❌
go.viam.com/rdk/components/arm/universalrobots 40% 0.00% ❌
go.viam.com/rdk/components/arm/wrapper 19% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 6% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 6% 0.00% ❌
go.viam.com/rdk/components/audioinput 53% +0.34% ➖
go.viam.com/rdk/components/base 56% 0.00% ➖
go.viam.com/rdk/components/base/agilex 62% 0.00% ➖
go.viam.com/rdk/components/base/boat 41% 0.00% ❌
go.viam.com/rdk/components/base/fake 53% 0.00% ➖
go.viam.com/rdk/components/base/wheeled 74% 0.00% ✅
go.viam.com/rdk/components/board 65% -0.15% ➖
go.viam.com/rdk/components/board/fake 38% 0.00% ❌
go.viam.com/rdk/components/board/genericlinux 22% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 64% 0.00% ➖
go.viam.com/rdk/components/camera/align 64% 0.00% ➖
go.viam.com/rdk/components/camera/fake 71% 0.00% ✅
go.viam.com/rdk/components/camera/ffmpeg 76% 0.00% ✅
go.viam.com/rdk/components/camera/rtsp 44% +0.86% ❌
go.viam.com/rdk/components/camera/transformpipeline 78% 0.00% ✅
go.viam.com/rdk/components/camera/videosource 34% 0.00% ❌
go.viam.com/rdk/components/encoder 68% 0.00% ➖
go.viam.com/rdk/components/encoder/AMS 3% 0.00% ❌
go.viam.com/rdk/components/encoder/fake 75% 0.00% ✅
go.viam.com/rdk/components/encoder/incremental 76% 0.00% ✅
go.viam.com/rdk/components/encoder/single 78% 0.00% ✅
go.viam.com/rdk/components/gantry 58% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 85% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 86% 0.00% ✅
go.viam.com/rdk/components/generic 82% 0.00% ✅
go.viam.com/rdk/components/gripper 67% 0.00% ➖
go.viam.com/rdk/components/input 86% 0.00% ✅
go.viam.com/rdk/components/input/fake 86% 0.00% ✅
go.viam.com/rdk/components/input/gpio 84% 0.00% ✅
go.viam.com/rdk/components/motor 76% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 63% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 69% 0.00% ➖
go.viam.com/rdk/components/motor/fake 56% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 66% +0.41% ➖
go.viam.com/rdk/components/motor/gpiostepper 52% 0.00% ➖
go.viam.com/rdk/components/motor/tmcstepper 62% 0.00% ➖
go.viam.com/rdk/components/motor/ulnstepper 52% 0.00% ➖
go.viam.com/rdk/components/movementsensor 74% 0.00% ✅
go.viam.com/rdk/components/movementsensor/adxl345 66% 0.00% ➖
go.viam.com/rdk/components/movementsensor/cameramono 45% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 36% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsrtk 29% 0.00% ❌
go.viam.com/rdk/components/movementsensor/mpu6050 83% 0.00% ✅
go.viam.com/rdk/components/posetracker 84% 0.00% ✅
go.viam.com/rdk/components/sensor 66% 0.00% ➖
go.viam.com/rdk/components/sensor/ultrasonic 31% 0.00% ❌
go.viam.com/rdk/components/servo 66% 0.00% ➖
go.viam.com/rdk/components/servo/gpio 71% 0.00% ✅
go.viam.com/rdk/config 78% 0.00% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 77% 0.00% ✅
go.viam.com/rdk/examples/customresources/demos/remoteserver 0% 0.00% ❌
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 71% 0.00% ✅
go.viam.com/rdk/module 76% 0.00% ✅
go.viam.com/rdk/module/modmanager 80% 0.00% ✅
go.viam.com/rdk/motionplan 71% -0.34% ✅
go.viam.com/rdk/operation 82% 0.00% ✅
go.viam.com/rdk/pointcloud 69% 0.00% ➖
go.viam.com/rdk/protoutils 49% 0.00% ❌
go.viam.com/rdk/referenceframe 72% 0.00% ✅
go.viam.com/rdk/registry 83% 0.00% ✅
go.viam.com/rdk/resource 84% 0.00% ✅
go.viam.com/rdk/rimage 77% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 75% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 86% 0.00% ✅
go.viam.com/rdk/robot/client 82% 0.00% ✅
go.viam.com/rdk/robot/framesystem 65% 0.00% ➖
go.viam.com/rdk/robot/impl 81% 0.00% ✅
go.viam.com/rdk/robot/packages 80% 0.00% ✅
go.viam.com/rdk/robot/server 53% 0.00% ➖
go.viam.com/rdk/robot/web 64% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol 71% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol/builtin 78% 0.00% ✅
go.viam.com/rdk/services/datamanager 75% 0.00% ✅
go.viam.com/rdk/services/datamanager/builtin 84% 0.00% ✅
go.viam.com/rdk/services/datamanager/datacapture 73% 0.00% ✅
go.viam.com/rdk/services/datamanager/datasync 0% 0.00% ❌
go.viam.com/rdk/services/mlmodel 84% 0.00% ✅
go.viam.com/rdk/services/mlmodel/tflitecpu 75% 0.00% ✅
go.viam.com/rdk/services/motion 53% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 86% 0.00% ✅
go.viam.com/rdk/services/navigation 54% 0.00% ➖
go.viam.com/rdk/services/sensors 74% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 25% 0.00% ❌
go.viam.com/rdk/services/slam 84% 0.00% ✅
go.viam.com/rdk/services/slam/builtin 74% 0.00% ✅
go.viam.com/rdk/services/slam/fake 90% 0.00% ✅
go.viam.com/rdk/services/slam/slam_copy/config 97% 0.00% ✅
go.viam.com/rdk/services/slam/slam_copy/dataprocess 71% 0.00% ✅
go.viam.com/rdk/services/slam/slam_copy/utils 100% 0.00% ✅
go.viam.com/rdk/services/vision 79% 0.00% ✅
go.viam.com/rdk/services/vision/builtin 73% 0.00% ✅
go.viam.com/rdk/session 97% 0.00% ✅
go.viam.com/rdk/spatialmath 84% 0.00% ✅
go.viam.com/rdk/subtype 92% 0.00% ✅
go.viam.com/rdk/utils 72% +0.18% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 66% (23196 / 35113) 0.00% ➖

@mrloureed mrloureed merged commit 6addd48 into viamrobotics:main Apr 19, 2023
12 checks passed
@mrloureed mrloureed deleted the bug-fix-border-color branch April 19, 2023 15:25
@micheal-parks micheal-parks mentioned this pull request Apr 19, 2023
Closed
bazile-clyde pushed a commit to bazile-clyde/rdk that referenced this pull request Jan 5, 2024
@mrloureed
Bug fix border color (viamrobotics#2243)
67a0657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micheal-parks micheal-parks micheal-parks approved these changes

@nathartman nathartman Awaiting requested review from nathartman

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
3 participants
@mrloureed @micheal-parks @viambot