Fix consumer #62
Merged
Fix consumer #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viartemev
force-pushed
the
fix-consumer
branch
from
ddf9c43
to
92a572d
Compare
Refactor it!This comment was generated by todo based on a
|
viartemev
force-pushed
the
fix-consumer
branch
2 times, most recently
from
8b57d9b
to
d978cf2
Compare
asm0dey
requested changes
Feb 7, 2019
| } catch (e: Exception) { | ||
| logger.error { "Can't send nack for deliveryTag: $deliveryTag" } | ||
| } finally { | ||
| throw RuntimeException(errorMessage) |
There was a problem hiding this comment.
I think we need some specific exception here for user to be able to implement some recover plan.
| try { | ||
| AMQPChannel.basicAck(deliveryTag, false) | ||
| } catch (e: Exception) { | ||
| val errorMessage = "Can't ack a message with deliveryTag: $deliveryTag" |
There was a problem hiding this comment.
Is it truth that if we've got exception then it's ack? What about ACK + IO exception?
There was a problem hiding this comment.
We use try-catch only for basicAck. A user is responsible for handling exceptions which can be thrown from the handler.
| } catch (e: Exception) { | ||
| val errorMessage = "Can't ack a message with deliveryTag: $deliveryTag" | ||
| logger.error { errorMessage } | ||
| throw RuntimeException(errorMessage) |
There was a problem hiding this comment.
I think we should throw some concrete exception here for user to be able to recover from error somehow.
viartemev
force-pushed
the
fix-consumer
branch
2 times, most recently
from
ba263c3
to
7aa85d4
Compare
viartemev
force-pushed
the
fix-consumer
branch
from
7aa85d4
to
22fdeae
Compare
Do we need coroutineScope here?This comment was generated by todo based on a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #39
closes: #38