URL encoding rework #1148
Merged
URL encoding rework #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Merging. |
s-ludwig
added a commit
that referenced
this pull request
Jul 4, 2015
| @@ -187,7 +199,7 @@ struct URL { | |||
| str = str[0 .. qi]; | |||
| } else m_queryString = null; | |||
|
|
|||
| m_pathString = str; | |||
| m_pathString = urlEncode(str, "/"); | |||
There was a problem hiding this comment.
I didn't realize this during the review, but this causes m_pathString to be encoded twice when URL is constructed from a string. Fixed by 9ae8806.
s-ludwig
added a commit
that referenced
this pull request
Jul 4, 2015
The new version is actually a bit too lax in theory, but the most important point is to never reject valid strings.
s-ludwig
added a commit
that referenced
this pull request
Jul 4, 2015
s-ludwig
added a commit
that referenced
this pull request
Jul 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.