New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #510: Support text blocks in Diet templates #518

Merged
merged 1 commit into from Feb 17, 2014

Conversation

Projects
None yet
2 participants
@nazriel
Contributor

nazriel commented Feb 13, 2014

Fix issue #510

Redo of #514 (which history got screwed up ;) )

Added tests for cases mentioned by Sönke

Some care needs to be taken to handle anything after the dot correctly:

    pre.test -> <pre class="test">
    pre.test. -> <pre class="test"> + block text
    pre. test -> <pre> + block text (jade apprently ignores the "test" in this case
    pre(). -> <pre> + block text
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 13, 2014

Member

Just one question - shouldn't the "blocktag" case be removed and the code moved into the if statement? At least Jade seems to treat "blocktag" as an ordinary tag.

Member

s-ludwig commented Feb 13, 2014

Just one question - shouldn't the "blocktag" case be removed and the code moved into the if statement? At least Jade seems to treat "blocktag" as an ordinary tag.

@nazriel

This comment has been minimized.

Show comment
Hide comment
@nazriel

nazriel Feb 13, 2014

Contributor

@s-ludwig you are totally right!
I should stop coding at those hours ;)

Btw, Sönke, DMD-head seems to be breaking stuff again... meh.
Should I report it or are you aware of it?

Contributor

nazriel commented Feb 13, 2014

@s-ludwig you are totally right!
I should stop coding at those hours ;)

Btw, Sönke, DMD-head seems to be breaking stuff again... meh.
Should I report it or are you aware of it?

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 14, 2014

Member

If you have time, that would be much appreciated! What did break this time?

Member

s-ludwig commented Feb 14, 2014

If you have time, that would be much appreciated! What did break this time?

@nazriel

This comment has been minimized.

Show comment
Hide comment
@nazriel

nazriel Feb 14, 2014

Contributor

@s-ludwig pull itself is updated.

DMD ~master issue reported here: #526

Contributor

nazriel commented Feb 14, 2014

@s-ludwig pull itself is updated.

DMD ~master issue reported here: #526

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 17, 2014

Member

Can you issue a quick rebase? Seems like the unit tests of the last pull request got in the way.

Member

s-ludwig commented Feb 17, 2014

Can you issue a quick rebase? Seems like the unit tests of the last pull request got in the way.

@nazriel

This comment has been minimized.

Show comment
Hide comment
@nazriel

nazriel Feb 17, 2014

Contributor

@s-ludwig done!
Sorry for delay, exams @ Uni 👻

Contributor

nazriel commented Feb 17, 2014

@s-ludwig done!
Sorry for delay, exams @ Uni 👻

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Feb 17, 2014

Member

Thanks, and good luck with the exams!

Member

s-ludwig commented Feb 17, 2014

Thanks, and good luck with the exams!

s-ludwig added a commit that referenced this pull request Feb 17, 2014

Merge pull request #518 from nazriel/issue510
Fix issue #510: Support text blocks in Diet templates

@s-ludwig s-ludwig merged commit a336373 into vibe-d:master Feb 17, 2014

1 check passed

default The Travis CI build passed
Details
@nazriel

This comment has been minimized.

Show comment
Hide comment
@nazriel

nazriel Feb 17, 2014

Contributor

@s-ludwig thanks for merging!

Contributor

nazriel commented Feb 17, 2014

@s-ludwig thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment