Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/close-on-transaction-complete-option #296

Merged
merged 2 commits into from
May 31, 2024

Conversation

hamza-fadil
Copy link
Contributor

Summary
Close transaction after submit

I added a switch to close after a transaction is complete. Sometime I missclick on submit twice and it duplicate the value, this should also close #253
Let me know if you want to change anything
Thank you

@victorbalssa victorbalssa self-requested a review May 30, 2024 21:03
@victorbalssa victorbalssa added this to the 0.17.0 milestone May 30, 2024
@victorbalssa victorbalssa changed the title Add close on transaction complete option feature/close-on-transaction-complete-option May 30, 2024
Copy link
Owner

@victorbalssa victorbalssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamza-fadil!

A few comment on translation and good to go 👍🏻

src/i18n/locale/translations/en-US.ts Outdated Show resolved Hide resolved
src/i18n/locale/translations/en-US.ts Outdated Show resolved Hide resolved
src/i18n/locale/translations/fr-FR.ts Outdated Show resolved Hide resolved
src/i18n/locale/translations/fr-FR.ts Outdated Show resolved Hide resolved
src/components/Screens/ConfigurationScreen.tsx Outdated Show resolved Hide resolved
@hamza-fadil
Copy link
Contributor Author

Hello, I applied the suggestions.
Thank you for your feedback.

@victorbalssa victorbalssa merged commit 827c430 into victorbalssa:develop May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature Request: checkbox to close or keep open Transaction Screen after clicking save
2 participants