Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE_ Internationalization for strings at the app #42

Merged
merged 12 commits into from
Oct 3, 2022

Conversation

carvalholeo
Copy link
Contributor


name: Pull request
about: Suggest an idea for this project
title: FEATURE_
labels: enhancement
assignees: victorbalssa


Is your feature request related to a problem? Please describe.
This PR implements a feature to have translations on all strings in the app. So, when someone using the app and their phone isn't using English as standard language, since have a translation, the app will be able to show them a string in their configured language.

Describe the solution you'd like
A clear and concise description of what you want to happen.
This solution uses Expo Localization, for understand into the app what languages are installed and I18N-JS, to make possible the translation from English. So, it's possible now to use Crowdin or others localization tools to make this work a community and open source task.

Describe alternatives you've considered
I think that only other alternative it's to compile the app for every language available 馃拃

@victorbalssa victorbalssa self-assigned this Sep 29, 2022
@victorbalssa victorbalssa linked an issue Sep 29, 2022 that may be closed by this pull request
Copy link
Owner

@victorbalssa victorbalssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!
really appreciate it.

I'll include this PR in the next update: 0.3.0.

@victorbalssa victorbalssa merged commit 317f1cb into victorbalssa:updates Oct 3, 2022
@victorbalssa victorbalssa added this to the 0.3.0 milestone Oct 3, 2022
This was referenced Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Translations i18n
2 participants