generated from victorbalssa/expo-ticket-app
-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE_ Internationalization for strings at the app #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove default export Change default location
Closed
victorbalssa
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
really appreciate it.
I'll include this PR in the next update: 0.3.0.
This was referenced Nov 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Suggest an idea for this project
title: FEATURE_
labels: enhancement
assignees: victorbalssa
Is your feature request related to a problem? Please describe.
This PR implements a feature to have translations on all strings in the app. So, when someone using the app and their phone isn't using English as standard language, since have a translation, the app will be able to show them a string in their configured language.
Describe the solution you'd like
A clear and concise description of what you want to happen.
This solution uses Expo Localization, for understand into the app what languages are installed and I18N-JS, to make possible the translation from English. So, it's possible now to use Crowdin or others localization tools to make this work a community and open source task.
Describe alternatives you've considered
I think that only other alternative it's to compile the app for every language available 馃拃