Skip archived messages in deleteMessages.js #392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dylif this works perfectly , i wrote the code for the full solution which prevents the api call, just testing it and will make a pr for it soon. |
|
@negswell Great. Thanks for doing that, it's even better. Shall I close with PR then? |
|
@dylif you could , i have raised a pr for the fix now. |
|
#393 fixes this issue better than I have. Please direct all attention there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix to continually skip archived messages when they are found in search. However, it does not prevent the archived messages from appearing in a search. Regardless, this partially fixes #242 as archived messages will be automatically skipped and not waste time.